Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c:
> return !params->output ? STATUS_SUCCESS : STATUS_BUFFER_TOO_SMALL;
>      }
>
> -    if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP)
> +    if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP))
>      {
>          BCRYPT_OAEP_PADDING_INFO *pad = params->padding;
>          gnutls_digest_algorithm_t dig;
>          gnutls_datum_t label;
>
> -        if (!pad || !pad->pszAlgId || !pad->pbLabel)
> +        /* Size-only OAEP queries can succeed without padding info, but an actual
> +         * OAEP encryption call requires padding info on native Windows. */

And here as well. Comments should generally be used to point out non-obvious facts.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130900