Re: [PATCH v3 0/11] MR8960: mshtml: Implement XDomainRequest.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/xmlhttprequest.c:
> return xhr_abort(&This->xhr);
>  }
>
> -static HRESULT HTMLXMLHttpRequest_open_hook(DispatchEx *dispex, WORD flags,
> -        DISPPARAMS *dp, VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller)
> +static HRESULT WINAPI xhr_open(struct xhr *xhr, BSTR bstrMethod, BSTR bstrUrl, VARIANT varAsync, VARIANT varUser, VARIANT varPassword)

I think it would be nicer to leave `VARIANT` conversion to callers and use bool and string types here. It's specific to XHR, so we can keep it there.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8960#note_116121