5 Dec
2024
5 Dec
'24
12:39 a.m.
On Wed Dec 4 09:07:24 2024 +0000, Rémi Bernon wrote:
No, I meant: if there's a race condition does this mean that functions are called concurrently from two different threads? In which case we should maybe add a CS. Or if it's just the consequence of a race condition elsewhere but functions still called from a single thread, these fixes are enough. Functions are not called concurrently. The game creates a media object, never sets a transform output type, and eventually calls `Flush()` on the object. For some reason this doesn't happen when tracing is not enabled. Not a race condition that causes invalid behaviour, since it's not invalid to call `Flush()`.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6950#note_89824