Re: [PATCH 0/6] MR5159: Overwatch highlight/POTG encoding (part 1)

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
> static HRESULT WINAPI media_sink_GetPresentationClock(IMFFinalizableMediaSink *iface, IMFPresentationClock **clock)
>  {
> -    FIXME("iface %p, clock %p stub!\n", iface, clock);
> +    struct media_sink *media_sink = impl_from_IMFFinalizableMediaSink(iface);
>
> -    return E_NOTIMPL;
> +    TRACE("iface %p, clock %p stub!\n", iface, clock);
> +
> +    if (!media_sink->clock)
> +        return MF_E_NO_CLOCK;
> +
> +    *clock = media_sink->clock;
> +    return S_OK;

Same thing, probably needs a lock. Also needs to AddRef on the returned clock.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5159#note_62623