27 Jul
2022
27 Jul
'22
1:28 p.m.
Giovanni Mascellani (@giomasce) commented about dlls/xactengine3_7/xact_dll.c:
XACT_GETOVERLAPPEDRESULT_CALLBACK pGetOverlappedResult; XACT_NOTIFICATION_CALLBACK notification_callback;
- void *wb_prepared_context; - void *wb_destroyed_context; + void *contexts[17];
Is this magic constant a good idea? Unfortunately we don't have a maximum constant for the notification types, but I'd rather go with `XACTNOTIFICATIONTYPE_MAX` and tolerate the wasted memory than leave a magic constant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/536#note_5060