On Tue May 28 19:09:14 2024 +0000, Esme Povirk wrote:
Well, if the purpose is to show that Windows doesn't activate the window, then that's wrong, isn't it? According to https://testbot.winehq.org/JobDetails.pl?Key=145848&f107=exe32.report&f111=e... and https://testbot.winehq.org/JobDetails.pl?Key=145849, it's not so much optional.
Sure, there's a couple of success but a vast majority of failures and I'm inclined to think that whatever is going on is more a bad interaction with some other tests than really some Windows behavior. Also, I think there's something fishy going on already, on the test results above even for the few successful runs there's still plenty of failed sequences but no test failures somehow? I don't know how this can happen but it doesn't look right. Fwiw the first commit alone looks okay, if you want to get `EVENT_SYSTEM_FOREGROUND` merged. The tests tweaking would probably need more investigation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853#note_71579