Re: [PATCH 0/3] MR8946: widl: Add metadata support for imported types.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about tools/widl/metadata.c:
> +{
> +    UINT namespace, assemblyref, scope;
> +    char *namespace_str;
> +    const char *import_name;
> +    type_t *base_type;
> +
> +    while (type_get_type( type ) == TYPE_POINTER) type = type_pointer_get_ref_type( type );
> +    base_type = type_get_real_type( type );
> +
> +    if (base_type->md.ref) return;
> +
> +    /* basic types don't get a reference */
> +    if (!base_type->name) return;
> +
> +    /* HSTRING is treated as a fundamental type */
> +    if (type->name && !strcmp( type->name, "HSTRING__" )) return;
> You're comparing type->name with "HSTRING" below, any good reason the two could not be the same?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8946#note_115562