Re: [PATCH v3 0/9] MR3300: jscript: WeakMap implementation.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/set.c:
> +
> +    RB_FOR_EACH_ENTRY_DESTRUCTOR(entry, entry2, &weakmap->map, struct weakmap_entry, entry)
> +        release_weakmap_entry(entry);
> +
> +    free(weakmap);
> +}
> +
> +static HRESULT WeakMap_gc_traverse(struct gc_ctx *gc_ctx, enum gc_traverse_op op, jsdisp_t *dispex)
> +{
> +    WeakMapInstance *weakmap = (WeakMapInstance*)dispex;
> +    struct weakmap_entry *entry, *entry2;
> +    HRESULT hres;
> +
> +    if(op == GC_TRAVERSE_UNLINK) {
> +        RB_FOR_EACH_ENTRY_DESTRUCTOR(entry, entry2, &weakmap->map, struct weakmap_entry, entry)
> +            release_weakmap_entry(entry);
> Same, this is not safe.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3300#note_39262