27 Jul
2022
27 Jul
'22
1:32 p.m.
Giovanni Mascellani (@giomasce) commented about dlls/xactengine3_7/xact_dll.c:
TRACE("(%p)->(%p)\n", This, pNotificationDesc);
unwrap_notificationdesc(&fdesc, pNotificationDesc); + This->contexts[pNotificationDesc->type - 1] = pNotificationDesc->pvContext;
Does it make sense to store this pointer? We're unregistering notifications, so we don't expect this context to be used anymore (until the next `RegisterNotification()` call, but then a new pointer will be given). Does the caller have any visibility into the pointer stored here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/536#note_5062