On Wed Feb 18 00:16:35 2026 +0000, Elizabeth Figura wrote:
Hello Elizabeth, thanks for your great feedback. I pushed v2 that addresses a few of the raised issues. But I have trouble adding the additional tests. What would an invalid address look like? Cases where sockaddr_to_unix returns zero. It's probably enough to test just one such case, e.g. if the address length is too small, or if the family is invalid. Thanks for the clarification. I added this in v3, and therefore moved in the implementation the event resetting below the call to sockaddr_to_unix.
For the test about the "successful connect": In this [Testbot run](https://testbot.winehq.org/JobDetails.pl?Key=161973) I added a connect to an open port, but I receive WSAEALREADY from native, when there is an event stored before. Is this somewhere near what you wanted to see? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10044#note_129980