Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/stb_dxt.h:
> dest[1] = (unsigned char)mn;
>     dest += 2;
>
> +   /*
> +    * Wine specific optimization to more closely match Windows behavior: If
> +    * max is equal to minimum, just set all bits to 0 (which means the value
> +    * is the value of max in this case).
> +    */
> +   if (mx == mn) {
> +      memset(dest, 0, 6);
> +      return;
> +   }

If I understand correctly, this affects the output. In which case I'd avoid calling it an optimization, both in the comment and the commit subject.
It's a bit of a pet peeve of mine, please bear with me...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117120