28 Jul
2025
28 Jul
'25
3:12 p.m.
On Mon Jul 28 15:12:33 2025 +0000, Esme Povirk wrote:
This leaks the value previously assigned to `This->filterspecs[i].pszName`. Also, elsewhere in the file, this variable is freed with `LocalFree` so I think we have to do the allocation with `LocalAlloc`. This->filterspecs uses HeapAlloc(), and StrDupW() uses LocalAlloc(). This is really confusing, so it's better to choose LocalAlloc() and LocalFree()
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8608#note_111182