25 Nov
2025
25 Nov
'25
3:41 p.m.
On Tue Nov 25 10:52:53 2025 +0000, Rémi Bernon wrote:
I think first_window should be read with ReadNoFence at least, at it's written through atomic ops. Isn't it a tiny bit nicer this way? The check is redundant. In the very rare potential case when it will read some stale data it will do `get_window_relative() call but will remain functionally correct with InterlockedExchange( &first_window, 0 ). But the vast majority of cases will go without fenced memory read.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9578#note_123677