Re: [PATCH v2 0/2] MR5007: winhttp: Add support for WINHTTP_AUTOPROXY_HOST_LOWERCASE flag in WinHttpGetProxyForUrl

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/winhttp/session.c:
> +    hostnameA = urlA + len_scheme;
> +    WideCharToMultiByte( CP_ACP, 0, uc.lpszHostName + uc.dwHostNameLength, -1,
> +            urlA + len_scheme + len_hostname, len, NULL, NULL );
>
> -        if ((ret = InternetGetProxyInfo( urlA, strlen(urlA),
> -                        hostnameA, strlen(hostnameA), &result, &len_result )))
> -        {
> -            ret = parse_script_result( result, info );
> -            free( result );
> -        }
> +    buffer.dwStructSize = sizeof(buffer);
> +    buffer.lpszScriptBuffer = script;
> +    buffer.dwScriptBufferSize = size;
> +
> +    if (!InternetInitializeAutoProxyDll( 0, NULL, NULL, NULL, &buffer ))
> +        return FALSE;
> urlA should be freed here. While you're at it, could you wrap lines at 120 columns?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5007#note_59927