Re: [PATCH v5 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
> +
> +        switch (type->class)
> +        {
> +            case HLSL_CLASS_ARRAY:
> +                if (idx >= type->e.array.elements_count)
> +                    return false;
> +
> +                *index += idx * type->e.array.type->reg_size[regset];
> +                break;
> +
> +            case HLSL_CLASS_STRUCT:
> +                *index += type->e.record.fields[idx].reg_offset[regset];
> +                break;
> +
> +            default:
> +                break;
> Numeric data types should never appear here because this is mean only for objects, right? In this case, I'd suggest to rather write `case OBJECT: break; default: vkd3d_unreachable();`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159#note_31213