On Wed Feb 25 17:52:11 2026 +0000, Paul Gofman wrote:
Even for ERR I'd also think a formally better place for that would be ntdll/unix/system.c:read_dev_urandom() (after checking that read to the requested size actually succeeded). But yet I am still failing to see how that changes anything in practice, the code is not supposed to fail there as well. Maybe assert( ret == len ) in the end of the function (with appropriate move ret definition) would make some sense. Hm, ok so I think this could instead be handled at different level by upgrading the existing `WARN` to `ERR` in `fill_random_buffer` and `assert` the failure case never happens in `SystemFunction036` (aka `RtlGenRandom`). E.g. something like https://gitlab.winehq.org/cdenton/wine/-/commit/93ed99966b316f4c9c1e03af7de5...
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130519