3 Oct
2025
3 Oct
'25
12:08 a.m.
Joel Holdsworth (@jhol) commented about dlls/shell32/tests/shelllink.c:
{ memset(buffer, '#', sizeof(buffer)); sii->cbSize = sizeof(SHSTOCKICONINFO); - hr = pSHGetStockIconInfo(i, SHGSI_ICONLOCATION, sii); + hr = pSHGetStockIconInfo(i, SHGSI_ICONLOCATION | SHGSI_ICON, sii);
ok(hr == S_OK, "%3d: got 0x%lx, iSysImageIndex: 0x%x, iIcon: 0x%x (expected S_OK)\n", i, hr, sii->iSysImageIndex, sii->iIcon);
+ todo_wine_if(sii->hIcon == 0) { + ok(sii->hIcon != 0, + "%3d: got %p, should be non-zero handle\n", + i, sii->hIcon); + } +
I think this needs to be indented +4 spaces, no? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_117494