7 Nov
2023
7 Nov
'23
1 p.m.
Giovanni Mascellani (@giomasce) commented about tests/shader_runner.c:
if (ret < 3) fatal_error("Malformed dispatch arguments '%s'.\n", line);
+ assert(runner->ops->dispatch);
I don't think all the `assert()`'s make sense. We can safely assume that ops are always defined, there is no need to check (or document) that. We don't usually check virtual function calls, AFAIA. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/434#note_51320