27 Mar
2023
27 Mar
'23
9:09 p.m.
Zebediah Figura (@zfigura) commented about dlls/msado15/filter.l:
+ +WINE_DEFAULT_DEBUG_CHANNEL(msado15); + +enum joined +{ + join_none, + join_and, + join_or +}; + +%} + +%% + +[ \t] { /* ignore all whitespace */ } ; +[0-9]+\.[0-9]+ { yylval->fval = atof(yytext); return T_FLOAT; } I don't know SQL, so this may be correct, but in other languages float values may include things like "1.", ".1", "1e-1", "-1.0", "1.0f" (including case). As elsewhere, tests around this area are always nice.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2498#note_28141