24 Aug
2023
24 Aug
'23
10:52 p.m.
Zebediah Figura (@zfigura) commented about dlls/winegstreamer/mfplat.c:
if (SUCCEEDED(IMFMediaType_GetUINT32(type, &MF_MT_MPEG2_LEVEL, &level))) format->u.video_h264.level = level; + + if (SUCCEEDED(IMFMediaType_GetAllocatedBlob(type, &MF_MT_MPEG_SEQUENCE_HEADER, &codec_data, &codec_data_len))) + { + assert(codec_data_len <= sizeof(format->u.video_h264.codec_data));
Should this really be an assert if it comes from user-supplied data? Would an FIXME/WARN/ERR be more appropriate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_43368