31 Oct
2022
31 Oct
'22
11:01 a.m.
Jacek Caban (@jacek) commented about dlls/mshtml/htmldoc.c:
- FIXME("(%p)->(%p)\n", This, p); + TRACE("(%p)->(%p)\n", This, p);
*p = NULL; - return S_OK; + + nsAString_InitDepend(&nsstr, NULL); + nsres = nsIDOMHTMLDocument_GetReferrer(This->nsdoc, &nsstr); + if(NS_FAILED(nsres)) + return map_nsresult(nsres); + + nsAString_GetData(&nsstr, &referrer); + *p = SysAllocString(referrer); + nsAString_Finish(&nsstr); + return *p || !referrer ? S_OK : E_OUTOFMEMORY;
You could just use `return_nsstr()` here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1172#note_12483