27 Jul
2023
27 Jul
'23
1:23 a.m.
Francisco Casas (@fcasas) commented about libs/vkd3d-shader/d3dbc.c:
put_u32(&buffer, D3DSIO_END);
- if (!(ret = buffer.status)) + if (buffer.status) + ctx->result = buffer.status; + + if (!ctx->result) { out->code = buffer.data; out->size = buffer.size; } - return ret; + return ctx->result;
Wouldn't we be leaking `buffer.data` in case `ctx->result != 0`, but `buffer.status = 0` ? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/288#note_40409