16 Oct
2025
16 Oct
'25
6:48 p.m.
Nikolay Sivov (@nsivov) commented about dlls/comctl32/toolbar.c:
static LRESULT TOOLBAR_SetVersion (TOOLBAR_INFO *infoPtr, INT iVersion) { +#if __WINE_COMCTL32_VERSION == 6 + return infoPtr->iVersion; +#else INT iOldVersion = infoPtr->iVersion;
+ if (iVersion > 5) + return -1; + infoPtr->iVersion = iVersion; return iOldVersion; +#endif } Could you factor this out to a helper that we could use from all three controls if it's exactly the same?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9191#note_118764