16 Sep
2024
16 Sep
'24
3:24 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
*dst_component = float_16_to_32(tmp); else if (format->type == FORMAT_ARGBF) *dst_component = *(float *)&tmp; + else if (format->type == FORMAT_ARGB_SNORM) + { + const uint32_t sign_bit = (1 << (format->bits[c] - 1));
```suggestion:-0+0 const uint32_t sign_bit = (1u << (format->bits[c] - 1)); ``` Similarly for the other `1`s used as first operand of a shift expression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6360#note_82304