29 Jul
2025
29 Jul
'25
10:34 a.m.
Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/main.c:
free( all_keys ); if (FAILED( hr )) { - for (i = 0; i < obj->cPropertyCount; i++) - free( ( (DEVPROPERTY *)obj[i].pProperties )->Buffer ); - free( (DEVPROPERTY *)obj->pProperties ); - obj->cPropertyCount = 0; - obj->pProperties = NULL; + DevFreeObjectProperties( *props_len, *props );
You could probably implement and use `DevFreeObjectProperties` separately, it would avoid mixing unrelated changes together. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8564#note_111293