Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
> -            {
> -                hr = IDirect3DCubeTexture9_LockRect(tex, f, m, &lock_rect, NULL, D3DLOCK_READONLY);
> -                ok(hr == D3D_OK, "Couldn't lock the texture, error %#x\n", hr);
> -                if (SUCCEEDED(hr))
> -                {
> -                    pitch = lock_rect.Pitch / sizeof(DWORD);
> -                    for (y = 0; y < size; y++)
> -                    {
> -                        for (x = 0; x < size; x++)
> -                        {
> -                            value = ((DWORD *)lock_rect.pBits)[y * pitch + x];
> -                            v[0] = (value >> 24) & 0xff;
> -                            v[1] = (value >> 16) & 0xff;
> -                            v[2] = (value >> 8) & 0xff;
> -                            v[3] = value & 0xff;
> +        ret = (value >> 15 & 0x1f) << 16
> Shouldn't that be
        ret = value >> 15 &lt;&lt; 24

?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19497