21 May
2025
21 May
'25
3:21 p.m.
Alexandre Julliard (@julliard) commented about tools/widl/metadata.c:
+}; + +static IMAGE_SECTION_HEADER section_header = +{ + .Name = ".text", + { .VirtualSize = 0 }, + .VirtualAddress = 0, + .SizeOfRawData = 0, + .PointerToRawData = 0, + .PointerToRelocations = 0, + .PointerToLinenumbers = 0, + .NumberOfRelocations = 0, + .NumberOfLinenumbers = 0, + .Characteristics = IMAGE_SCN_CNT_CODE | IMAGE_SCN_MEM_READ +}; + If you are going to use designated initializers, it doesn't seem necessary to list all the zero fields. Particularly for `.DataDirectory`, it would be a lot more readable as `[IMAGE_DIRECTORY_ENTRY_COM_DESCRIPTOR] = { ... }`.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8037#note_104104