On Thu Oct 23 14:17:45 2025 +0000, Rémi Bernon wrote:
Can glGetString really return NULL? What about making this more readable? ```suggestion:-22+0 const char *str, *ptr; char *out; if (!(str = (const char *)funcs->p_glGetString( GL_EXTENSIONS ))) str = ""; for (ptr = str; *ptr; ptr++) if (ptr == str || (ptr[0] == ' ' && ptr[1])) size++; if (ptr > str && ptr[-1] == ' ') ptr--; /* strip trailing space */ if (!(extensions = malloc( size * sizeof(*extensions) + (ptr - str) ))) return; out = (char *)&extensions[size]; memcpy( out, str, ptr - str ); for (ptr = strtok( out, " " ); ptr; ptr = strtok( NULL, " " )) extensions[count++] = ptr; assert( count + ARRAY_SIZE(legacy_extensions) - 1 == size ); ``` It returns NULL on core contexts. Those should usually fall into version >= 3.0 branch, so it's it requires additional weirdness, but I've seen it with d3d11 tests when I hacked things to test this branch.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9263#note_119459