22 Sep
2022
22 Sep
'22
8:03 a.m.
Huw Davies (@huw) commented about server/registry.c:
if ((key = create_key( parent, &name, 0, KEY_WOW64_64KEY, 0, sd ))) { - load_registry( key, req->file ); + filename = calloc( 1, req_data_len + 1 ); + memcpy( filename, req_data, req_data_len );
We've still got the `calloc()` here (you've changed it to a `malloc()` in a later patch). Note, not that it matters, but I'd do the `memcpy()` before appending the final `'\0'` - it seems more logical that way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_9030