Re: [PATCH v2 0/3] MR6855: server: Fix renaming file to a hardlink of itself.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about server/fd.c:
> }
>
> /* when creating a hard link, source cannot be a dir */
> -    if (create_link && !fstat( fd->unix_fd, &st ) && S_ISDIR( st.st_mode ))
> +    if (create_link && !fstat( fd->unix_fd, &src_st ))
> +    {
> +        src_st_filled = 1;

(Interim comment) How about we just unconditionally call `fstat` here? `src_st_filled` looks error-prone anyway.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6855#note_88711