Re: [PATCH v16 0/4] MR6423: Implement NtQuerySystemEnvironmentValueEx, NtQuerySystemInformation SystemBootEnvironmentInformation, GetFirmwareType, GetFirmwareEnvironmentVariable*

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/kernel32/process.c:
> */
>  BOOL WINAPI GetFirmwareType(FIRMWARE_TYPE *type)
>  {
> +    ULONG ret_size;
> +    SYSTEM_BOOT_ENVIRONMENT_INFORMATION boot_info = {0};
> +
>      if (!type)
>          return FALSE;
>
> -    *type = FirmwareTypeUnknown;
> +    if(!set_ntstatus(NtQuerySystemInformation(SystemBootEnvironmentInformation,
> +                                              &boot_info, sizeof(boot_info), &ret_size)))
> +        return FALSE;
> It's possible you can get rid of ret_size.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6423#note_81376