Re: [PATCH v4 0/4] MR2258: winegstreamer: Support WMV DMO decoder.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wmv_decoder.c:
> +            .height = 1080,
> +        },
> +    };
> +    struct wg_transform *transform;
> +    struct wmv_decoder *decoder;
>      HRESULT hr;
>
> TRACE("outer %p, out %p.\n", outer, out);
>
> -    if (!(impl = calloc(1, sizeof(*impl))))
> +    if (!(transform = wg_transform_create(&input_format, &output_format)))
> +    {
> +        ERR_(winediag)("GStreamer doesn't support WMV decoding, please install appropriate plugins.\n");
> +        return E_FAIL;
> +    }
> +    wg_transform_destroy(transform);
> You also need to support the creation failure in the test `CoCreateInstance` call.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2258#note_25374