10 Oct
2024
10 Oct
'24
1:26 p.m.
The first patch is no-op. While it's often fine, it doesn't improve bisects. I'd suggest something like: - A patch that introduces `Identifier` rule, including `ES5Keyword` and a test of affected rule - A patch that adds `noassoc` changes, a rule that depends on it and its tests - A patch that uses `Identifier` rule in more places (possibly a few patches, up to you) - A patch for `LabelledStatement`, it would be nice to have a comment about why we can't use `Identifier` there -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6618#note_84580