Hans Leidekker (@hans) commented about dlls/bcrypt/bcrypt_main.c:
if (!(flags & BCRYPT_USE_SYSTEM_PREFERRED_RNG)) return STATUS_INVALID_HANDLE; } + /* Pseudo algorithm handles are denoted by having the lowest bit set. + * An aligned algorithm pointer will never have this bit set. + */ + else if ((uintptr_t)algorithm & 1 == 1) + { + if (algorithm != BCRYPT_RNG_ALG_HANDLE) { + FIXME( "pseudo-handle algorithm %p not supported\n", algorithm); + return STATUS_NOT_IMPLEMENTED; + } + }
Please put the comment inside the 'if else' block. The condition should read 'else if (((ULONG_PTR)algorithm & 1) == 1)'. Put the opening brace for the inner block on a new line like in the surrounding code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/812#note_8083