7 Oct
2025
7 Oct
'25
7:46 p.m.
On Tue Oct 7 11:44:39 2025 +0000, Rémi Bernon wrote:
Fwiw the reason I did it with a local variable is because as a general rule I think it's better to avoid accessing/writing to pointers within a loop. I also find it more readable to have the results of a computation only written at some specific sucesss/failure points rather than being spread around, and it could be arguably incorrect to return a failure while still having modified the array (which I indeed did as well in my suggestion, but that could more easily be changed). Shouldn't matter much here anyway. Ah, fair. Rewrote the function, thanks.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9045#note_117885