22 Aug
2023
22 Aug
'23
2:51 p.m.
Jacek Caban (@jacek) commented about dlls/kernelbase/process.c:
RtlFreeUnicodeString( &newdirW );
if (flags & CREATE_NEW_PROCESS_GROUP) - params->ConsoleFlags = 1; + { + if (!(flags & CREATE_NEW_CONSOLE)) + params->ConsoleFlags = 1; + } else params->ProcessGroupId = NtCurrentTeb()->Peb->ProcessParameters->ProcessGroupId;
It could be slightly simplified by swapping ifs order: ``` if (!(flags & CREATE_NEW_PROCESS_GROUP)) //... else if (!(flags & CREATE_NEW_CONSOLE)) //... ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3442#note_43039