Re: [PATCH v10 0/4] MR4852: Add support from AudioPathConfig

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/dmime/audiopath.c:
> +                WARN("Unknown %s\n", debugstr_chunk(&chunk));
> +            break;
> +        case MAKEFOURCC('p','b','g','d'):
> +            FIXME("Undocumented %s\n", debugstr_chunk(&chunk));
> +            break;
> +        default:
> +            WARN("Unknown %s\n", debugstr_chunk(&chunk));
> +            break;
> +        }
> +
> +        if (FAILED(hr))
> +            break;
> +    }
> +
> +    if (FAILED(hr) && pchannel_to_buffer)
> +        free(pchannel_to_buffer);
    if (FAILED(hr))
        free(pchannel_to_buffer);

Fwiw I would do the same as below, moving the `list_add_tail` call here. Maybe even returning an error if hr is successful but pchannel_to_buffer is NULL.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4852#note_57948