9 Jun
2023
9 Jun
'23
2:02 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d/command.c:
+ WARN("Range tile counts must not be NULL when range count is > 1.\n"); + return; + } + + vkd3d_mutex_lock(&command_queue->op_mutex); + + if (!(op = d3d12_command_queue_op_array_require_space(&command_queue->op_queue))) + { + ERR("Failed to add op.\n"); + goto done; + } + + op->opcode = VKD3D_CS_OP_UPDATE_MAPPINGS; + memset(&op->u.update_mappings, 0, sizeof(op->u.update_mappings)); + op->u.update_mappings.resource = resource_impl; + op->u.update_mappings.heap = heap_impl; It seems `AddRef()` should be called here.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216#note_35270