5 Jun
2025
5 Jun
'25
2:55 p.m.
Panayiotis Talianos (@panintended) commented about dlls/d3dx9_36/effect.c:
else { free(param->shared_data->parameters); + param->shared_data->parameters = NULL; /* Zeroing table size is required as the entry in pool parameters table can be reused. */ param->shared_data->size = 0; param->shared_data = NULL;
@yshui Shouldn't the below also be `free`d and set to `NULL`? ```c free(param->shared_data->data); param->shared_data->data = NULL; free(param->shared_data); param->shared_data = NULL; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8214#note_105525