25 Jan
2023
25 Jan
'23
noon
Jinoh Kang (@iamahuman) commented about dlls/windows.media.speech/recognizer.c:
return S_OK;
error: + if (session->capture_client) IAudioCaptureClient_Release(session->capture_client); + if (session->audio_client) IAudioClient_Release(session->audio_client); if (session->constraints) IVector_ISpeechRecognitionConstraint_Release(session->constraints); + CloseHandle(session->worker_control_event);
Closing a potentially NULL handling is confusing. How about: ```suggestion:-0+0 if (session->worker_control_event) CloseHandle(session->worker_control_event); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1948#note_21764