4 Aug
2023
4 Aug
'23
12:35 p.m.
Jeffrey Smith (@whydoubt) commented about dlls/mfmediaengine/main.c:
if (SUCCEEDED(IMFPresentationDescriptor_GetUINT64(pd, &MF_PD_DURATION, &duration))) { /* Convert 100ns to seconds. */ - engine->duration = duration / 10000000; + engine->duration = (double)duration / 10000000;
Not sure if the lead devs have a preference on this one, but `= duration / 10000000.0` compiles to the same thing. I also prefer `1e7` over `10000000.0` because that many 0's is hard to read at a glance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3510#note_41341