3 Jun
2024
3 Jun
'24
5:47 a.m.
Elizabeth Figura (@zfigura) commented about dlls/winegstreamer/video_decoder.c:
IMFMediaType_Release(decoder->output_type); IMFMediaType_AddRef((decoder->output_type = type));
+ /* WMV decoder outputs RGB formats with default stride forced to negative, likely a result of internal conversion to DMO media type */ + if (!decoder->IMediaObject_iface.lpVtbl || FAILED(video_decoder_set_default_stride(decoder->output_type, &output_type)))
Isn't failure from video_decoder_set_default_stride() only exceptional? Falling back to the previous type seems odd here in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5732#note_72158