Re: [PATCH 0/4] MR7707: msvcp140: Implement codecvt<char16_t, char> conversions.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcp140/tests/msvcp140.c:
> +    consume_header = 4,
> +    generate_header = 2,
> +    little_endian = 1
> +} codecvt_convert_mode;
> +
> +/* class codecvt<char16> */
> +typedef struct {
> +    codecvt_base base;
> +    unsigned int max_code;
> +    codecvt_convert_mode convert_mode;
> +} codecvt_char16;
> +
> +static codecvt_char16 *(__thiscall * p_codecvt_char16_ctor)(codecvt_char16 *this);
> +static codecvt_char16 *(__thiscall * p_codecvt_char16_ctor_refs)(codecvt_char16 *this, unsigned int refs);
> +static codecvt_char16 * (__thiscall * p_codecvt_char16_ctor_mode)(codecvt_char16 *this, void *locinfo,
> +        ULONG max_code, codecvt_convert_mode mode, unsigned int refs);
static codecvt_char16 * (__thiscall * p_codecvt_char16_ctor)(codecvt_char16 *this);
static codecvt_char16 * (__thiscall * p_codecvt_char16_ctor_refs)(codecvt_char16 *this, size_t refs);
static codecvt_char16 * (__thiscall * p_codecvt_char16_ctor_mode)(codecvt_char16 *this, void *locinfo,
        ULONG max_code, codecvt_convert_mode mode, size_t refs);

Why are you changing last argument type to `unsigned int`? It doesn't match with mangled function name. There are similar changes that needs to be undone in implementation.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7707#note_99512