On Thu Nov 6 22:12:02 2025 +0000, Fabian Maurer wrote:
That's because `ExecuteCabW` has the following code: ``` if ((pCab->pszCab && *pCab->pszCab) && (pCab->pszInf && *pCab->pszInf) && *pCab->szSrcPath) { // SNIP } hr = install_init(pCab->pszInf, pCab->pszSection, pCab->szSrcPath, pCab->dwFlags, &info); ``` Which implies that `pCab->pszInf` can be NULL, but it's dereferenced in `install_init` later. I thought I'd correct that mistake, but if you think it's fine as is, feel free to close this - there's currently no program I know of affected by it. If it's dereferenced anyway, and there's no app that crashes on this, it means that the NULL check is not necessary and can be removed.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_121138