13 Nov
2024
13 Nov
'24
12:30 p.m.
Jacek Caban (@jacek) commented about dlls/mshtml/script.c:
+ return E_UNEXPECTED; + + if(!IsEqualGUID(&CLSID_JScript, &prop->script_host->guid) || + IActiveScript_QueryInterface(prop->script_host->script, &IID_IWineJScript, (void **)&jscript) != S_OK) + return S_OK; + + hres = IWineJScript_GlobalPropExists(jscript, prop->id); + IWineJScript_Release(jscript); + return hres; + } + case GLOBAL_ELEMENTVAR: { + IHTMLElement *elem; + BSTR bstr; + + if(!(bstr = SysAllocString(prop->name))) + return E_OUTOFMEMORY; I think it would be better to just store the name as `BSTR` instead.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6721#note_87304