On Tue Nov 11 02:39:35 2025 +0000, Yuxuan Shui wrote:
I think failing is better than returning the wrong result. Application might have a fallback code path, but if we return incorrect result it may do something unexpected. I made this change because it makes writing the test a bit simpler. i.e. I can check if `CreateToolhelp32Snapshot` fails and return early, and not need to bother with adding more `todo`s. there are lots of other ways to make your test simpler starting from not calling CreateToolhelp32Snapshot + MODULE32 when running the tests on Wine
and failing on eg. PROCESS|HEAP while we were returning success (without any heap information) is a major change, wrong IMO, and completely orthogonal to this MR -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9371#note_121485