20 Jul
2023
20 Jul
'23
11:02 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
VKD3D_SM4_DIMENSION_NONE = 0x0, VKD3D_SM4_DIMENSION_SCALAR = 0x1, VKD3D_SM4_DIMENSION_VEC4 = 0x2, + + VKD3D_SM4_DIMENSION_INVALID = ~0,
Maybe it's ok anyway, but I would suggest `~0u`, as in general bitwise operations on signed operands are likelier to hit UB than on unsigned operands. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281#note_39591