Re: [PATCH v7 0/2] MR8459: urlmon: Add PersistentZoneIdentifier semi-stub

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/urlmon/zone_id.c:
> +    if (!file_name)
> +    {
> +        if (!This->save_file_name)
> +            return E_INVALIDARG;
> +
> +        file_name = This->save_file_name;
> +        remember = FALSE;
> +    }
> +
> +    /* FIXME: Write zone information to Zone.Identifier NTFS alternate data stream */
> +
> +    hfile = CreateFileW(file_name, GENERIC_READ | GENERIC_WRITE,
> +        FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, OPEN_ALWAYS,
> +        FILE_ATTRIBUTE_NORMAL, NULL);
> +    if (hfile == INVALID_HANDLE_VALUE)
> +        return HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND);
> Should it be `return HRESULT_FROM_WIN32(GetLastError());`?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8459#note_109718