30 Nov
2024
30 Nov
'24
3:18 a.m.
On Mon Nov 25 19:19:31 2024 +0000, Gabriel Ivăncescu wrote:
I haven't changed this, mostly because I don't know exactly what you meant. I updated with changes and the cached idea, let me know what you think when you're back. Like, wine (regardless of this patch) is doing `free( name );` and then early return. That doesn't *look* right to me. I feel like we're still supposed to do the following checks (e.g., permissions check, get\_inode check, etc) even if src and dest are the same file. But the current tests are too lacking to verify if what I'm claiming is true.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6855#note_89287