30 Jan
2024
30 Jan
'24
10:05 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/spirv.c:
{ int ret = VKD3D_OK;
+ if (TRACE_ON() && !vsir_instruction_is_dcl(instruction) && instruction->handler_idx != VKD3DSIH_NOP) + vkd3d_spirv_build_op_line(&compiler->spirv_builder, compiler->location.line); I like the idea, but it shouldn't probably be gated on `TRACE_ON()`. I'd rather add another `VKD3D_SHADER_CONFIG` option.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/612#note_59479